Fix vertical scaling of Eisenstein diagrams for p-adic families - #19
Closed
roed-math wants to merge 2 commits into
Closed
Fix vertical scaling of Eisenstein diagrams for p-adic families#19roed-math wants to merge 2 commits into
roed-math wants to merge 2 commits into
Conversation
…B#6828) The aspect ratio of the family Eisenstein diagram was capped at a fixed value of 8 in data coordinates, so families with large e and small slopes (e.g. 2.1.16.16a, 2.1.32.34a) rendered as vertically compressed slivers with overlapping y-axis labels. Since the image is displayed at a fixed width, what matters is the physical height:width ratio aspect*maxslope/xwidth; replace the fixed cap by clamping that ratio to [1/4, 5/4]. A survey over all 489714 stored families with w>0 shows no diagram shrinks, ~2.5% (the compressed ones) grow by >5%, and typical families are byte-identical. Verified by rendering all nine pages named in the issue plus controls via the test client and measuring the embedded PNGs; added a regression test doing the same. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
GPT signed off. |
Owner
Author
|
Superseded by LMFDB#7155, opened upstream from this same branch. Closing here; review continues upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Eisenstein diagram on p-adic family pages capped its matplotlib aspect ratio at a fixed value$e$ $[1/4, 5/4]$ instead$w>0$ shows no diagram
of 8 in data coordinates. Since the image is displayed at a fixed width, families with large
and small slopes (all nine examples in the issue) rendered as vertically compressed slivers with
overlapping y-axis labels. This keeps the two existing aspect terms (default shape and minimum
label separation) but clamps the physical height:width ratio of the image to
of capping the raw aspect. A survey over all 489,714 stored families with
gets shorter, ~2.5% (exactly the compressed ones) grow by more than 5%, and typical families are
byte-identical; the nine pages named in the issue now render with height:width 0.40–1.17 instead
of 0.06–0.25. Also adds a regression test that measures the embedded PNG on three family pages.
Addresses LMFDB#6828.
🤖 Generated with Claude Code